(maint) Refactor in-memory cache objects #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the inmemory cache objects duplicated the object properties of the Sidecar protocol but this is not necessary. This commit changes the inmemory cache object to instead inherits from the sidecar and extends it. The from_sidecar! method is modified to dynamically copy the object instead of hardcoded values.
glennsarti
force-pushed
the
maint-refactor-cache
branch
from
02f65da to
b1dc150
Compare
2 tasks
jpogran
approved these changes
Jun 10, 2019
Contributor
jpogran
left a comment
jpogran
left a comment
There was a problem hiding this comment.
this stretches the definition of a maint commmit, but i'll allow it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the in-memory cache objects duplicated the object properties of the
Sidecar protocol but this is not necessary. This commit changes the inmemory
cache object to instead inherits from the sidecar and extends it. The
from_sidecar! method is modified to dynamically copy the object instead of
hardcoded values.